[Theme APPROVED] WonderCMS black theme version 2.*

turboblack · Post by **turboblack** » Fri Feb 09, 2018 3:38 pm

is based on a standard template, added some changes, logo, background, button up, and social icons.

HWU · Post by **HWU** » Mon Feb 12, 2018 2:33 pm

Hello turboblack

Thank you for the new template. Looks nice, clean and simple.

I took out the code für social media buttons for to use it on my demo-page (or my WonderCMS playground - what ever...):

http://webpin.ch/wonder

Have a nice week!

turboblack · Post by **turboblack** » Mon Feb 12, 2018 2:47 pm

I noticed that you do not have links to buttons, replace sharp links with social networks

example:

change

Code: Select all

<a href="#" class="fa fa-facebook"></a>

to

Code: Select all

<a href="https://www.facebook.com/denya.danylenko" class="fa fa-facebook"></a>

have a nice day )))

will youu share a feedback script?

HWU · Post by **HWU** » Wed Feb 14, 2018 3:00 pm

Hello turboblack

Thank you for the note about using SM-Links. I know how it works, but on my different playgrounds it's not necessary to create working links.

I have tried out your form mailer and it works fine. A link to a german version on one of my playgrounds you will find on my WonderCMS installation on http://www.webpin.ch/wonder or directly on http://www.webpin.ch/wonder5

Greetings, Heinz

Post by **wiz** » Wed Feb 14, 2018 8:43 pm

Thanks for sharing turbo, nice indeed!

I'll be reviewing it later and if everything is okay, it will be added to the themes repository.

HWU, I love your playground! Any chance of sharing your inventions on GitHub, so the world can see and possibly use it?

turboblack · Post by **turboblack** » Thu Feb 15, 2018 10:12 am

greetings, glad that you like it - always please

I periodically try to find something useful for the engine,

Yes, you can use a template, it was created for this purpose

https://github.com/turboblack/black/releases

see the release, I think it's all right

Post by **wiz** » Sat Feb 17, 2018 11:00 pm

I managed to review this theme. There are a couple of small issues that should be fixed before we submit this theme to the official WonderCMS repository.

1. There are two versions of jQuery in the theme.
- <script type="text/javascript" src="http://code.jquery.com/jquery-1.4.4.min.js"></script>
- <script src="https://code.jquery.com/jquery-1.12.4.min.js" integrity="sha256-ZosEbRLbNQzLpnKIkEdrPv7lOy9C27hHQ+Xp8a4MxAQ=" crossorigin="anonymous"></script>
FIX: There should be one library of jQuery to avoid any conflicts and additional page loading times. Remove one library?

2. There are hard coded icons included in the theme. If you remove them, the theme will be 100% usable and doesn't need editing when the users install it for the first time.

Code: Select all

<!-- Add font awesome icons -->
<center>
<a href="#" class="fa fa-facebook"></a>
<a href="#" class="fa fa-twitter"></a>
<a href="#" class="fa fa-youtube"></a>
<a href="#" class="fa fa-instagram"></a>
<a href="#" class="fa fa-vk"></a>
<a href="#" class="fa fa-skype"></a>
</center>

FIX: You can add the icons code to the theme READ ME file, and somebody can add them to the theme if they want to.

Below is a cleaned up theme.php with all of the issues above FIXED + code clean up (spaces to tabs, translated "Back to top" to english, and removed russian comments in the code). I also added an additional comment in theme.php. I also added "integrity" hashes to the included files (CSS and JS).

Fixed theme.php:

Code: Select all

<!DOCTYPE html>
<html lang="en">
<head>
<link href="themes/black/favicon.ico" rel="shortcut icon" type="image/x-icon" />
	<meta charset="UTF-8">
	<meta http-equiv="X-UA-Compatible" content="IE=edge">
	<meta name="viewport" content="width=device-width, initial-scale=1">
	<title><?=wCMS::get('config','siteTitle')?> - <?=wCMS::page('title')?></title>
	<meta name="description" content="<?=wCMS::page('description')?>">
	<meta name="keywords" content="<?=wCMS::page('keywords')?>">
	<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha256-916EbMg70RQy9LHiGkXzG8hSg9EdNy97GazNG/aiY1w=" crossorigin="anonymous">
	<link rel="stylesheet" href="<?=wCMS::asset('css/style.css')?>">
	<?=wCMS::css()?>
	<meta name="viewport" content="width=device-width, initial-scale=1">
	<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" integrity="sha256-eZrrJcwDc/3uDhsdt61sL2oOBY362qM3lon1gyExkL0=" crossorigin="anonymous">
</head>
<body>

	<?=wCMS::alerts()?>
	<?=wCMS::settings()?>
	<nav class="navbar navbar-default">
		<div class="container">
			<div class="col-sm-5 text-center">
				<div class="navbar-header">
					<button type="button" class="navbar-toggle" data-toggle="collapse" data-target="#navMobile">&#9776;</button>
					<a href="./"><h3><?=wCMS::get('config','siteTitle')?><span class="navbar" id="logo"></h3></a>
				</div>
			</div>
			<div class="col-sm-7 text-center">
				<div class="collapse navbar-collapse" id="navMobile">
					<ul class="nav navbar-nav navbar-right">
						<?=wCMS::menu()?>
					</ul>
				</div>
			</div>
		</div>
	</nav>

	<div class="container">
		<div class="col-xs-12 col-sm-8">
			<div class="whiteBackground grayFont padding20 rounded5">
				<?=wCMS::page('content')?>
			</div>
		</div>
		<div class="col-xs-12 col-sm-4">
			<div class="visible-xs spacer20"></div>
			<div class="blueBackground padding20 rounded5">
				<?=wCMS::block('subside')?>
				<br>

				<!-- Add font awesome between these comment blocks -->



				<!-- Add font awesome icons HERE -->

			</div>
		</div>
	</div>

	<footer class="container-fluid">
		<div class="padding20 text-right">
			<?=wCMS::footer()?>
		</div>
	</footer>

		<script src="https://code.jquery.com/jquery-1.12.4.min.js" integrity="sha256-ZosEbRLbNQzLpnKIkEdrPv7lOy9C27hHQ+Xp8a4MxAQ=" crossorigin="anonymous"></script>
		<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha256-U5ZEeKfGNOja007MMD3YBI0A3OSZOQbeG6z2f2Y0hu8=" crossorigin="anonymous"></script>
		<?=wCMS::js()?>
	<?=wCMS::js()?>
	<div id="scroller" class="b-top" style="display: none;"><span class="b-top-but">Back to top</span></div>
	<script type="text/javascript">
	$(document).ready(function() {
		$("body").css("display", "none");
		$("body").fadeIn(1000);

		$("a.fade").click(function(event){
			event.preventDefault();
			linkLocation = this.href;
			$("body").fadeOut(1000, redirectPage);
		});
		function redirectPage() {
			window.location = linkLocation;
		}
	});
	</script>
	<script type="text/javascript">
		$(document).ready(function(){
			$(window).scroll(function () {if ($(this).scrollTop() > 0) {$('#scroller').fadeIn();} else {$('#scroller').fadeOut();}});
			$('#scroller').click(function () {$('body,html').animate({scrollTop: 0}, 400); return false;});
		});
	</script>
</body>
</html>

All you have to do is:
1. Save this theme.php again with the code below (ZIP it again as a release, like the first time here: https://github.com/turboblack/black/releases).
2. Add the social icons HTML to the READ ME file (users can add them manually, I removed them from the theme.php to make it 100% usable without having to edit theme.php since first install).
3. Test the theme to see if everything works - because I removed one jQuery library (removed the 1.4.4 version). If it doesn't work, I will provide another fix.

turboblack · Post by **turboblack** » Sun Feb 18, 2018 10:58 am

https://github.com/turboblack/black/rel ... ag/black-2

done ^-)

Post by **wiz** » Thu Feb 22, 2018 4:34 pm

Almost perfect, I tried installing theme through Settings->Themes & plugins and it didn't work.

Problem: You had a folder within a folder black-black-2/black
Solution: The only thing that should be inside the ZIP file should be the black folder with no subfolders.

I have attached the correct ZIP file below, use this for your release file (replace it here: https://github.com/turboblack/black/releases).

black.zip: Release file.; (56.16 KiB) Downloaded 1287 times

Everything else seems good!

turboblack · Post by **turboblack** » Fri Feb 23, 2018 1:41 pm

corrected the oversight sorry for hemorrhoids

_________________________________________
26.02.18

began to check the version that you threw off on your local computer and it's so beaten that I can not understand what's what, and decided to stop at the previous one. so that the release will be for those who know how to use ftp))

in any case, a person will install the script through FTP, which means that he should be given a freebie with a link, if they want, they will set themselves a template manually.

WonderCMS community

[Theme APPROVED] WonderCMS black theme version 2.*

[Theme APPROVED] WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*

Re: WonderCMS black theme version 2.*