Custom module - installation from Github in the wrong folder.

Post Reply
User avatar
c0mp0ser
Posts: 40
Joined: Mon Jan 02, 2017 11:59 am

Custom module - installation from Github in the wrong folder.

Post by c0mp0ser »

I have started my own adventure with Github. I used this tutorial to create a new module for Wonder CMS:
https://github.com/robiso/wondercms/wiki/Custom-modules
Unfortunately I have a problem. The module installs in the "/plugins/plugin-name-master" folder. So far I can't find the cause. Someone can help?
Link to source: https://github.com/pawell0/summernote-editor
Solving this problem will help me when publishing my Materialize theme on Github.
viewtopic.php?p=6432#p6432
It's just me, an unmeasurable particle of the cosmos ...
https://pawelkruzel.m00n.link
https://m00n.link
User avatar
wiz
Admin
Posts: 667
Joined: Sat Oct 30, 2010 12:23 am

Re: Custom module - installation from Github in the wrong folder.

Post by wiz »

Thanks for reporting the issue, opened a bug report and it will be fixed with the next version: https://github.com/robiso/wondercms/issues/259
User avatar
c0mp0ser
Posts: 40
Joined: Mon Jan 02, 2017 11:59 am

Re: Custom module - installation from Github in the wrong folder.

Post by c0mp0ser »

wiz wrote: Sat May 14, 2022 12:37 pm Thanks for reporting the issue, opened a bug report and it will be fixed with the next version: https://github.com/robiso/wondercms/issues/259
Thank you. BTW, have you perhaps glanced at the description of this plugin in my Github ...? 😉 Just asking.
It's just me, an unmeasurable particle of the cosmos ...
https://pawelkruzel.m00n.link
https://m00n.link
User avatar
wiz
Admin
Posts: 667
Joined: Sat Oct 30, 2010 12:23 am

Re: Custom module - installation from Github in the wrong folder.

Post by wiz »

I checked and looking forward to testing it, great effort!

We tried reporoducing this issue and the summernote editor extracted correctly. This used to be a bug in the old version
Did you copy the full RAW url to the wcms-modules.json file when trying ti installing it?

https://raw.githubusercontent.com/pawel ... dules.json

Also which version of WonderCMS are you using?

There are additional issues:
1. Your repository should be renamed to summernote-editor-lite
2. Make sure the name changes also happen in the plugin itself and wcms-modules.json to avoid overwriting the current Summernote editor on your website.
3. The summernote-editor.php file also has to reflect these changes.


If you somehow manage to reproduce the "-master" added issue, please provide steps to reproduce.
User avatar
c0mp0ser
Posts: 40
Joined: Mon Jan 02, 2017 11:59 am

Re: Custom module - installation from Github in the wrong folder.

Post by c0mp0ser »

Thanks for your expertise. I will go through the code and correct what is needed. Will try to install the plugin using a different web browser. Maybe it will change something. I will dump the history and temporary files. We'll see.
It's just me, an unmeasurable particle of the cosmos ...
https://pawelkruzel.m00n.link
https://m00n.link
User avatar
c0mp0ser
Posts: 40
Joined: Mon Jan 02, 2017 11:59 am

Re: Custom module - installation from Github in the wrong folder.

Post by c0mp0ser »

I made some code changes and now the plugin installs normally. I tested this on my Mac on MAMP and on a production server using a fairly fresh installation of WCMS 3.3.1 there, all in the latest Firefox, switched to not storing history, temporary files and cookies.

At this stage of development, the plugin requires you to install any other plugin that includes jQuery (not the original Summernote Editor of course). I suggest installing the Additional Content plugin. The theme's style sheet should contain the styles needed to properly display modals and some buttons and other small Summernote Editor Lite elements.

I'm guessing that the original Summernote Editor plugin uses Bootstrap because of the lack of additional icons. There are a very limited number of icons in the "Summernote" font that the editor uses to display icons. But this can be tried to get around in various ways. I used SVG, borrowed from Google Materialize Symbols.

I still think that references to any frameworks etc should be removed from plugins. And such versions of some plugins I intend to make myself.
Now I can continue the work, but there is a lot more ... 😉
It's just me, an unmeasurable particle of the cosmos ...
https://pawelkruzel.m00n.link
https://m00n.link
Post Reply